serializers/crate: Prevent categories and keywords from being cleared
#10721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
force-pushed
the
fix-crate-serializer
branch
from
c19467e to
147d5da
Compare
Turbo87
reviewed
Feb 28, 2025
eth3lbert
force-pushed
the
fix-crate-serializer
branch
from
147d5da to
521fa42
Compare
Contributor
Author
|
those failures in CI seem unrelated to this PR. |
…ared Previously, if `categories` and `keywords` of `crate` had existing values, they would be cleared from query results if those value returned null. This caused issues when `crate` was peeked from the store. This commit detects null values and ignores the fields instead of updating them.
Turbo87
force-pushed
the
fix-crate-serializer
branch
from
521fa42 to
e68f24a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
categoriesandkeywordsofcratehad existing values, they would be cleared from query results if those value returned null. This caused issues whencratewas peeked from the store. This commit detects null values and ignores the fields instead of updating them.Fixes #10711 .